Fallback on swift-frontend -scan-dependencies ... fallback path in case libSwiftScan shared library cannot be loaded.
#1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
commented
May 9, 2024
| do { | ||
| try interModuleDependencyOracle.verifyOrCreateScannerInstance(fileSystem: fileSystem, | ||
| swiftScanLibPath: scanLibPath) | ||
| if isCachingEnabled { |
There was a problem hiding this comment.
@cachemeifyoucan should we error if caching is enabled but we failed to load libSwiftScan?
There was a problem hiding this comment.
Error out sounds good to me.
artemcm
changed the title
swift-frontend -scan-dependencies ... fallback path in case libSwiftScan shared library cannot be loaded.
There was a problem hiding this comment.
This only fixes broken libSwiftScan. I do believe if you want driver to load a broken scanner, you deserve a hard error with no fallback. Warning doesn't do anything in this case and user will assume they didn't do anything horrible if they don't hit any error afterwards.
| do { | ||
| try interModuleDependencyOracle.verifyOrCreateScannerInstance(fileSystem: fileSystem, | ||
| swiftScanLibPath: scanLibPath) | ||
| if isCachingEnabled { |
There was a problem hiding this comment.
Error out sounds good to me.
|
@swift-ci test |
…case libSwiftScan shared library cannot be loaded. Resolves rdar://127768140
|
@swift-ci test |
owenv
approved these changes
May 13, 2024
|
@swift-ci test Windows platform |
artemcm
changed the title
swift-frontend -scan-dependencies ... fallback path in case libSwiftScan shared library cannot be loaded.swift-frontend -scan-dependencies ... fallback path in case libSwiftScan shared library cannot be loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://127768140