[Caching] Handle emit module job correctly for swift caching #1602
Conversation
cachemeifyoucan
requested review from
akyrtzi,
xymus,
nkcsgexi,
benlangmuir and
artemcm
|
@swift-ci please test |
| @@ -119,14 +119,21 @@ extension Driver { | |||
| commandLine.appendPath(abiPath.file) | |||
| outputs.append(abiPath) | |||
| } | |||
| let cacheContributingInputs = inputs.enumerated().reduce(into: [(TypedVirtualPath, Int)]()) { result, input in | |||
| // only the first swift input contributes to an emit module job. | |||
There was a problem hiding this comment.
What do you mean by contribute here? I assume it's specific to the cache?
There was a problem hiding this comment.
The way we create cache key for compilation is we have one cache key per input file, and each cache key contains all the output files for that specific input (like .o, .d, .diag). All the module level outputs are attached to the first swift input file.
This is just computing all the input file that has a cache key because there is an output produced that linked to the cache key for this input file.
There was a problem hiding this comment.
Could you please add this to the comment here?
There was a problem hiding this comment.
Added to the same function in CompileJob which is more complicated and worth explanation.
| @@ -119,14 +119,21 @@ extension Driver { | |||
| commandLine.appendPath(abiPath.file) | |||
| outputs.append(abiPath) | |||
| } | |||
| let cacheContributingInputs = inputs.enumerated().reduce(into: [(TypedVirtualPath, Int)]()) { result, input in | |||
| // only the first swift input contributes to an emit module job. | |||
There was a problem hiding this comment.
Could you please add this to the comment here?
There are two situations when emiting modules are not correctly handled when swift caching is enabled: * When only `-emit-module` task is requested from driver, in this case, we are contructing a `CompileJob` but only generating module output. SwiftDriver still expects all swift inputs will have a cache key even only the first file is generating outputs and has a cache key. * When using `-experimental-emit-module-separately`, then swift-driver needs to construct a `EmitModuleJob`, which wasn't taught the concept of caching and not producing any cache key. rdar://127768967
cachemeifyoucan
force-pushed
the
eng/PR-127768967
branch
from
9338bdc to
b5c3534
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
There are two situations when emiting modules are not correctly handled when swift caching is enabled:
-emit-moduletask is requested from driver, in this case, we are contructing aCompileJobbut only generating module output. SwiftDriver still expects all swift inputs will have a cache key even only the first file is generating outputs and has a cache key.-experimental-emit-module-separately, then swift-driver needs to construct aEmitModuleJob, which wasn't taught the concept of caching and not producing any cache key.rdar://127768967