[Option] Support MultiArg options #1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needed to support: swiftlang/swift#73601 |
|
@swift-ci please test |
cachemeifyoucan
force-pushed
the
eng/PR-multi-arg-support
branch
from
143899e to
8e42d4c
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
owenv
reviewed
May 14, 2024
| } | ||
| let endIdx = index + Int(option.numArgs) | ||
| parsedOptions.addOption(option, argument: .multiple(Array())) | ||
| arguments[index..<endIdx].map { String($0) }.forEach { parsedOptions.addInput($0) } |
There was a problem hiding this comment.
Will this index off the end of the array if the user doesn't provide enough args?
There was a problem hiding this comment.
Good catch. Added a testcase for that too.
Teach SwiftOption to handle MultiArg options, including generating Options from Options.td, etc. Even the only MultiArg option in swift is a NoDriver option, still teach the OptionTable to parse such options to future proof the implementation.
cachemeifyoucan
force-pushed
the
eng/PR-multi-arg-support
branch
from
8e42d4c to
62c300b
Compare
|
@swift-ci please test |
artemcm
approved these changes
May 14, 2024
owenv
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach SwiftOption to handle MultiArg options, including generating Options from Options.td, etc. Even the only MultiArg option in swift is a NoDriver option, still teach the OptionTable to parse such options to future proof the implementation.