[Explicit Module Builds] Get source locations from the dependency scanner and emit diagnostics with them #1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
reviewed
May 14, 2024
| @@ -71,8 +72,18 @@ public enum DependencyScanningError: LocalizedError, DiagnosticData, Equatable { | |||
| } | |||
|
|
|||
| @_spi(Testing) public struct ScannerDiagnosticPayload { | |||
| @_spi(Testing) public struct SourceLocation : DiagnosticLocation { | |||
There was a problem hiding this comment.
Can we promote this type + its members to API so clients can attempt to cast to it / access the fields without parsing the textual representation?
nkcsgexi
approved these changes
May 14, 2024
…nner and emit diagnostics with them - Adopt new libSwiftScan API to get source location for each emitted diagnostic: buffer identifier, line number, column number.
artemcm
force-pushed
the
DepScanSourceLocs
branch
from
f4e1328 to
de435b9
Compare
owenv
approved these changes
May 14, 2024
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses functionality added in: [Dependency Scanning] Specify Source Locations For Missing Module Dependencies swift#73600