Skip to content

Pass through -compiler-assertions to the compiler #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

tbkka
Copy link
Contributor

@tbkka tbkka commented May 29, 2024

Pass through -compiler-assertions to the compiler to enable run-time-switchable assertions

@tbkka tbkka requested a review from artemcm May 29, 2024 01:13
@tbkka
Copy link
Contributor Author

tbkka commented May 29, 2024

@artemcm Did I do this right?

@tbkka
Copy link
Contributor Author

tbkka commented May 29, 2024

@swift-ci Please test

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct.
But just-in-case, here's the procedure typically used to update Options.swift:
https://github.com/apple/swift-driver?tab=readme-ov-file#rebuilding-optionsswift

@tbkka tbkka force-pushed the tbkka-compiler-assertions branch from 6166a95 to ae271ca Compare May 31, 2024 22:53
@tbkka
Copy link
Contributor Author

tbkka commented May 31, 2024

@swift-ci Please test

@tbkka
Copy link
Contributor Author

tbkka commented Jun 3, 2024

@swift-ci Please test Windows platform

@tbkka tbkka merged commit 5932ca4 into swiftlang:main Jun 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants