[Tests][Explicit Module Builds] Fix per-test state in incremental explicitly-built module tests to avoid conflicts on parallel test runs #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licitly-built module tests to avoid conflicts on parallel test runs
|
@swift-ci test |
| @@ -19,10 +19,7 @@ import TestUtilities | |||
|
|
|||
| // MARK: - Instance variables and initialization | |||
| final class IncrementalCompilationTests: XCTestCase { | |||
|
|
|||
| var tempDir: AbsolutePath = try! AbsolutePath(validating: "/tmp") | |||
There was a problem hiding this comment.
We're not hardcoding /tmp to use as a temporary directory, are we? We should have something similar to LLVM's implementation:
https://github.com/llvm/llvm-project/blob/ca33796d54ce6d2c711032b269caf32851c5915a/llvm/lib/Support/Unix/Path.inc#L1452
There was a problem hiding this comment.
That's the default, but it does get overridden for each test in the setUp.
adrian-prantl
approved these changes
Jun 12, 2024
| @@ -90,15 +109,38 @@ final class IncrementalCompilationTests: XCTestCase { | |||
|
|
|||
| override func setUp() { | |||
| self.tempDir = try! withTemporaryDirectory(removeTreeOnDeinit: false) {$0} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.