[Linux] Add build-id support. #1641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
artemcm
approved these changes
Jul 9, 2024
Sources/SwiftOptions/Options.swift
Outdated
| @@ -58,6 +58,8 @@ extension Option { | |||
| public static let bridgingHeaderDirectoryForPrint: Option = Option("-bridging-header-directory-for-print", .separate, attributes: [.helpHidden, .frontend, .noDriver], metaVar: "<path>", helpText: "Directory for bridging header to be printed in compatibility header") | |||
| public static let bridgingHeaderPchKey: Option = Option("-bridging-header-pch-key", .separate, attributes: [.helpHidden, .frontend, .noDriver], helpText: "Cache Key for bridging header pch") | |||
| public static let bsdk: Option = Option("-bsdk", .joinedOrSeparate, attributes: [.noDriver, .argumentIsPath], helpText: "path to the baseline SDK to import frameworks") | |||
| public static let buildIdEQ: Option = Option("-build-id=", .joined, alias: Option.buildId) | |||
There was a problem hiding this comment.
LGTM.
The usual reminder that these Options.swift are to be generated as follows:
https://github.com/swiftlang/swift-driver?tab=readme-ov-file#rebuilding-optionsswift
In case they were not, for this change.
There was a problem hiding this comment.
Oh, interesting. They were not. I will investigate that — thank you.
Add a `-build-id` option to the driver to let users control the build ID setting used by the linker. Pass `--build-id` to the linker by default, so that build IDs are enabled by default but using the linker's default type; if someone wishes to specify a particular option, they can do so using the new driver option. Also turn on build IDs when *building* the driver. rdar://116798309
Options.swift needs to be generated from the one in the Swift repo, not edited by hand. Based on the Options.td from swiftlang/swift#75435. rdar://116798309
al45tair
force-pushed
the
eng/PR-116798309
branch
from
955dd5a to
87d48ea
Compare
|
@artemcm Hmmm. Looks like I'm not the only one that's edited |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
-build-idoption to the driver to let users control the build ID setting used by the linker. Pass--build-idto the linker by default, so that build IDs are enabled by default but using the linker's default type; if someone wishes to specify a particular option, they can do so using the new driver option.Also turn on build IDs when building the driver.
rdar://116798309