Skip to content

[6.0] Add In-process plugin server path #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 26, 2024

Cherry-pick #1616 into release/6.0

(copied from swiftlang/swift#74740)

  • Explanation: swift-syntax libraries in compiler has been complied with -enable-library-evolution because the toolchain provides them as a public interface for building plugins (i.e. lib/swift/host/*.swiftmodule). But that was not great for the performance in the compiler. This PR changes that by separating swift-syntax libs for the compiler from the one for the plugins. So the compiler and the plugin now can use different version/ABI of swift-syntax libraries from the compiler. Now swift-syntax for the compiler are compiled without library evolution.
  • Scope: Macro plugins
  • Risk: Mid. This changes the mechanism of in-process plugins significantly. Now in-process plugins are communicate with the compiler using the same messaging serialization with other plugins (i.e. swift-plugin-server, and other executable plugins), instead of directly calling the Macro.Type expansion method. Also, to separate the swift-syntax libraries, this introduces another set of shared swift-syntax libraries in the toolchain.
  • Testing: Passes current test suite.
  • Issue: rdar://130532628
  • Reviewer: Hamish Knight (@hamishknight) Alex Hoppen (@ahoppen) Ben Barham (@bnbarham)

(cherry picked from commit 2e9f154)
@rintaro
Copy link
Member Author

rintaro commented Jun 26, 2024

@rintaro
Copy link
Member Author

rintaro commented Jul 20, 2024

Decided not to merge

@rintaro rintaro closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant