Ignore prebuilt module cache when building the prebuilt module cache #1650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building modules for an SDK, we need to ignore any existing prebuilt modules to avoid building a partial prebult module cache. Do so by passing an intentially-bad path for the prebuilt module cache path that's derived from the output path (but not the same as that path). This prohibits the frontend scanning job from adding the default prebuilt module cache path, while ensuring that we find no prebuilt modules. Fixes rdar://131183526.
|
@swift-ci please test |
tshortli
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: When building modules for an SDK, we need to ignore any existing prebuilt modules to avoid building a partial prebuilt module cache. Make sure we do ignore them by passing down an intentionally-bogus path for the existing prebuilt module cache.
Scope: Prebuilt module cache generation logic only, very narrow.
Risk: Very low due to narrow scope.
Testing: Passes current test suite.
Main PR: #1649
Issue: rdar://131183526