Skip to content

[6.0 🍒][Test Only] Make CachingBuildTests.testDependencyScanning be adaptable to scanner diagnostic revisions #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2024
Merged

[6.0 🍒][Test Only] Make CachingBuildTests.testDependencyScanning be adaptable to scanner diagnostic revisions #1659

merged 1 commit into from
Jul 12, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jul 10, 2024 •
edited
Loading

@artemcm
[Test Only] Make CachingBuildTests.testDependencyScanning be adapta…
c7d3e92 
…ble to scanner diagnostic revisions

Instead of throwing a failure, a scan may return a hollow result carrying diagnostic error payload
@artemcm artemcm mentioned this pull request Jul 10, 2024
Merged
@artemcm
Copy link
Contributor Author

artemcm commented Jul 11, 2024

@swift-ci test

@artemcm artemcm requested a review from nkcsgexi July 11, 2024 23:13
@artemcm artemcm merged commit 76bb150 into swiftlang:release/6.0 Jul 12, 2024
3 checks passed
@artemcm artemcm deleted the 60TestFixForCachingDiags branch July 12, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@nkcsgexi nkcsgexi Awaiting requested review from nkcsgexi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artemcm @bnbarham