PrebuiltModuleGen: fail prebuilt module generation job when critical modules failed to build #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modules failed to build Generating prebuilt modules for critical modules is important because missing them has a bigger impact on the overall build time. This change adds a report of generated modules when the job finishes and fails the prebuilt module job if some selected critical modules were missing. rdar://132094476
|
@swift-ci please test |
artemcm
approved these changes
Jul 30, 2024
| stderrStream.flush() | ||
| } | ||
| let keyModules = ["Swift", "SwiftUI", "Foundation"] | ||
| return keyModules.allSatisfy { compiledModules.keys.contains($0) } |
There was a problem hiding this comment.
We could also emit to stderr specifically which one is missing, to save the trouble to the person examining this output.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating prebuilt modules for critical modules is important because missing them has a bigger impact on the overall build time. This change adds a report of generated modules when the job finishes and fails the prebuilt module job if some selected critical modules were missing.
rdar://132094476