Skip to content

Add a C (@_cdecl) API for the driver's getSingleFrontendInvocationFromDriverArguments #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Aug 9, 2024

This will enable non-Swift clients to query this utility as an alternative to the legacy C++ driver's equivalent.

@artemcm artemcm requested review from DougGregor and bnbarham August 9, 2024 22:28
@artemcm
Copy link
Contributor Author

artemcm commented Aug 9, 2024

@swift-ci test

@artemcm artemcm force-pushed the PrepareForCompilerTooling branch from 38391d0 to 43116a6 Compare August 9, 2024 23:04
@artemcm
Copy link
Contributor Author

artemcm commented Aug 9, 2024

@swift-ci test

@artemcm artemcm force-pushed the PrepareForCompilerTooling branch from 43116a6 to 7de6666 Compare August 12, 2024 18:17
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't realized that getSingleFrontendInvocationFromDriverArguments was so close to what we needed. Neat!

@artemcm artemcm marked this pull request as ready for review August 12, 2024 18:35
…FromDriverArguments`

This will enable non-Swift clients to query this utility as an alternative to the legacy C++ driver's equivalent.
@artemcm artemcm force-pushed the PrepareForCompilerTooling branch from 7de6666 to 6b79789 Compare August 12, 2024 18:41
@artemcm
Copy link
Contributor Author

artemcm commented Aug 12, 2024

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Aug 12, 2024

@swift-ci test Windows platform

@artemcm artemcm merged commit 4b6c86a into swiftlang:main Aug 12, 2024
3 checks passed
@artemcm artemcm deleted the PrepareForCompilerTooling branch August 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants