Skip to content

Fix ExplicitModuleBuildTests: testExplicitLinkLibraries & testDependencyGraphDotSerialization & CachingBuildTests: testSeparateModuleJob & testModuleOnlyJob #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Aug 15, 2024

  • testExplicitLinkLibraries to account for possibility of multiple link libraries per dependency
  • testDependencyGraphDotSerialization to account for possibility of discovering prebuilt modules for stdlib
  • testSeparateModuleJob & testModuleOnlyJob: Do not always hard-code a macOS triple and pass in explicit stdlib paths to the driver invocations

…ncyGraphDotSerialization

- testExplicitLinkLibraries to account for possibility of multiple link libraries per dependency
- testDependencyGraphDotSerialization to account for possibility of discovering prebuilt modules for stdlib
Do not always hard-code a macOS triple and pass in explicit stdlib paths to the driver invocations
@artemcm artemcm changed the title Fix ExplicitModuleBuildTests: testExplicitLinkLibraries & testDependencyGraphDotSerialization Fix ExplicitModuleBuildTests: testExplicitLinkLibraries & testDependencyGraphDotSerialization & CachingBuildTests: testSeparateModuleJob & testModuleOnlyJob Aug 15, 2024
@artemcm
Copy link
Contributor Author

artemcm commented Aug 15, 2024

@swift-ci test

Copy link
Contributor

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@al45tair al45tair merged commit effb4e5 into swiftlang:main Aug 16, 2024
3 checks passed
@artemcm artemcm deleted the FixTestsEBM branch August 16, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants