Skip to content

Maintain relative SDK paths with no -working-directory flag #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

rmaz
Copy link
Contributor

@rmaz rmaz commented Oct 10, 2024

When providing relative SDK paths to the swift-driver, the path should be
passed directly to the frontend as a relative path. This is necessary to
support remotely building Swift objects that are shared across machines
without serializing invalid absolute paths.

@rmaz
Copy link
Contributor Author

rmaz commented Oct 10, 2024

@swift-ci please test

@rmaz
Copy link
Contributor Author

rmaz commented Oct 10, 2024

@swift-ci Please test Windows platform

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@rmaz rmaz merged commit 9dd6657 into swiftlang:main Oct 11, 2024
3 checks passed
@rmaz rmaz deleted the relsdkpath branch October 11, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants