[6.2][cherrypick] Detect OpenBSD opt-out of BTCFI. #1878
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the swift side, we added a new build flavor in swiftlang/swift#80389 to opt-out of BTCFI as a way of working around swiftlang/swift#80059. We communicate this to swift-driver via the frontend with FrontendTargetInfo.
DougGregor
approved these changes
Apr 19, 2025
|
@swift-ci please test |
|
@swift-ci please test. |
4 similar comments
|
@swift-ci please test. |
|
@swift-ci please test. |
|
@swift-ci please test. |
|
@swift-ci please test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the swift side, we added a new build flavor in swiftlang/swift#80389 to opt-out of BTCFI as a way of working around swiftlang/swift#80059. We communicate this to swift-driver via the frontend with FrontendTargetInfo.
This is required in 6.2 to properly parallel the changes made on the swift side, even if builds default to BTCFI disabled.
Changes are limited to OpenBSD.
See swiftlang/swift#80059 and the OpenBSD port issue in swiftlang/swift#78437
#1857
Minimal, since changes are scoped only to OpenBSD.
CI has ran on the original prs. OpenBSD nobtcfi-flavored builds require this change.
@DougGregor