Validate optimizations when a match fails #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to catch the case where a match occurs without optimizations, but doesn't occur with optimizations. Additionally fix the `xfail` param such that it can't be used on tests that actually match expectations.
|
@swift-ci please test |
rctcwyvrn
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
I ran into this same issue while working on #525 and ended up implementing a similar change https://github.com/apple/swift-experimental-string-processing/pull/525/files#diff-9420a6ee27325155caaa6f4ae0692789b51ae1066736319212df0fcc52c67dbf
Yours covers more cases and fixes the xfail thing so I'm fine with taking your changes over mine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to catch the case where a match occurs without optimizations, but doesn't occur with optimizations. Additionally fix the
xfailparam such that it can't be used on tests that actually match expectations.