Lint pipeline improvements; fix enabling/disabling of lint rules. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an older version of SwiftSyntax, SyntaxVisitor was a class and thus the lint rules were as well. When SwiftSyntax changed SyntaxVisitor to be a protocol with mutating methods, we lost the ability to treat the rules polymorphically in certain situations due to Swift language limitations. Now that SwiftSyntax generates a class version of SyntaxVisitor, we can bring that old design back.
RuleMask previously only kept track of rule disablement, assuming that any range where a rule was not disabled should have it enabled. This isn't quite correct; it's actually a tri-state of enabled, disabled, and whatever-is-in-the-configuration. With these changes, rule enablement/disablement is now handled in the lint pipeline (format pipeline coming later), not in individual rules. (This will actually be refined later, because some individual rules do need finer control over that check.) Fixes SR-11114.
akyrtzi
approved these changes
Jul 23, 2019
allevato
added a commit
to allevato/swift-format
that referenced
this pull request
Jul 23, 2019
This mostly completes what was started in swiftlang#16, except for the part about giving certain rules finer control than just detection based on the line number of the node being visited. Fixes SR-11114.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have lint rules extend
SyntaxVisitorBaseand make them classes againinstead of using the visitor protocol.
RuleMaskpreviously only kept track of rule disablement, assuming thatany range where a rule was not disabled should have it enabled. This
isn't quite correct; it's actually a tri-state of enabled, disabled, and
whatever-is-in-the-configuration.
With these changes, rule enablement/disablement is now handled in the
lint pipeline (format pipeline coming later), not in individual rules.
(This will also be refined later, because some individual rules do
need finer control over that check.)
Fixes SR-11114.