Lint pipeline improvements; fix enabling/disabling of lint rules. #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have lint rules extend
SyntaxVisitorBase
and make them classes againinstead of using the visitor protocol.
RuleMask
previously only kept track of rule disablement, assuming thatany range where a rule was not disabled should have it enabled. This
isn't quite correct; it's actually a tri-state of enabled, disabled, and
whatever-is-in-the-configuration.
With these changes, rule enablement/disablement is now handled in the
lint pipeline (format pipeline coming later), not in individual rules.
(This will also be refined later, because some individual rules do
need finer control over that check.)
Fixes SR-11114.