Skip to content

[SR-13194] DoNotUseSemicolons should not strip semicolons which separate a 'do' blocks from 'while' blocks. #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2020
Merged

[SR-13194] DoNotUseSemicolons should not strip semicolons which separate a 'do' blocks from 'while' blocks. #210

merged 1 commit into from
Jul 13, 2020

Conversation

karwa
Copy link
Contributor

@karwa karwa commented Jul 11, 2020 •
edited by allevato
Loading

This semi-colon is required, and removing it breaks code.

I've never used the syntax APIs before, so not sure if this is the right way to do it, but it works.

Fixes SR-13194.

@karwa karwa changed the base branch from swift-5.2-branch to master July 11, 2020 17:51
allevato
allevato approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@allevato allevato merged commit cb4e621 into swiftlang:master Jul 13, 2020
@allevato allevato mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allevato allevato allevato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karwa @allevato