Skip to content

Fix comment for multiElementCollectionTrailingCommas #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fix comment for multiElementCollectionTrailingCommas #710

merged 2 commits into from
Mar 27, 2024

Conversation

ozumin
Copy link
Contributor

@ozumin ozumin commented Mar 26, 2024

According to the test case below, I thought

let MyCollection = [1, 2,]

would always be

let MyCollection = [1, 2]

regardless of multiElementCollectionTrailingCommas configuration.
https://github.com/apple/swift-format/blob/5545cf668ad61840162a51de97e4bc16ad666844/Tests/SwiftFormatTests/PrettyPrint/CommaTests.swift#L108-L144

Please close this PR if I misunderstood the issue 🙏

@allevato allevato mentioned this pull request Mar 26, 2024
Open
allevato
allevato approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that oversight!

@allevato allevato merged commit 07c5509 into swiftlang:main Mar 27, 2024
@ahoppen ahoppen mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allevato allevato allevato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozumin @allevato