Update README.md to make it platform agnostic #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the README platform agnostic
0xTim
requested review from
ahoppen,
allevato,
bnbarham and
shawnhyam
as code owners
allevato
reviewed
Oct 7, 2024
README.md
Outdated
|
|
||
| Xcode 16 and above include swift-format in the toolchain. You can run `swift-format` from anywhere on the system using `swift format` (notice the space instead of dash). To find the path at which `swift-format` is installed, run `xcrun --find swift-format`. | ||
| Swift 6 (included with Xcode 16) and above include swift-format in the toolchain. You can run `swift-format` from anywhere on the system using `swift format` (notice the space instead of dash). To find the path at which `swift-format` is installed on macOS, run `xcrun --find swift-format`. |
There was a problem hiding this comment.
"on macOS" might be better expressed as "in Xcode".
@ahoppen Thoughts on wording here from Apple's end?
There was a problem hiding this comment.
Is the last sentence needed if the section is now generically "in the Swift Toolchain"?
There was a problem hiding this comment.
I think we should keep it because usually people don’t know the path of the toolchain inside Xcode. And I agree that in Xcode makes more sense.
ahoppen
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the README platform agnostic