build: install linker files for installed targets #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
jmschonfeld
reviewed
Jul 22, 2024
Ensure that we install any linker files for the modules which are required on certain platforms.
|
@swift-ci please test |
|
Thanks, this seems fine to me! Before merging could we kick off a toolchain build or full swift test with this change just to get some good coverage over the CMake changes? We don't have that setup on this repo yet so it'll need to be kicked off via a PR to the swiftlang/swift repo (or the swift-corelibs-foundation repo) to double check this doesn't cause any issues in the toolchain build on linux+windows |
|
Sure! Kicked that off at swiftlang/swift#65907. I'll follow up with the installer changes later, I want to get this in to unblock CI |
jmschonfeld
approved these changes
Jul 22, 2024
compnerd
added a commit
to compnerd/swift-foundation
that referenced
this pull request
Jul 23, 2024
)" This reverts commit 590caaa. This introduces a failure in the Ubuntu 20.04 test suite (e.g. https://ci.swift.org/job/oss-swift-pr-test-ubuntu-20_04/7131/).
jmschonfeld
pushed a commit
that referenced
this pull request
Jul 23, 2024
This reverts commit 590caaa. This introduces a failure in the Ubuntu 20.04 test suite (e.g. https://ci.swift.org/job/oss-swift-pr-test-ubuntu-20_04/7131/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we install any linker files for the modules which are required on certain platforms.