WiX: integrate signing support into the MSBuild path #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than requiring external scripting to sign the installer components, add in integrated code-signing capability into the build. With this, a user can specify additional parameters when invoking the build: `-p:SignOutput=true -p:CERTIFICATE=... -p:PASSPHRASE=...`. By default the output is not code-signed, allowing control over the build, which is also useful for CI usage. This reduces some of the extra logic required for signing in the CI systems.
shahmishal
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than requiring external scripting to sign the installer components, add in integrated code-signing capability into the build. With this, a user can specify additional parameters when invoking the build:
-p:SignOutput=true -p:CERTIFICATE=... -p:PASSPHRASE=.... By default the output is not code-signed, allowing control over the build, which is also useful for CI usage. This reduces some of the extra logic required for signing in the CI systems.