-
Notifications
You must be signed in to change notification settings - Fork 43
debian: add initial control files for debian packaging #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC: @shahmishal |
Package: swift-runtime | ||
Version: @VERSION@ | ||
Architecture: @ARCH@ | ||
Maintainer: Swift Open Source Project <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May consider adding a "Homepage" field here which links to https://swift.org
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd also consider replacing swift-
prefix with swiftlang-
, discussion here:
https://forums.swift.org/t/rpm-and-debs-for-swift-call-for-the-community/49117/35
The packaging on debian mostly requires the control files and a pre-configured layout to package as a root. This adds the control files as a starting point.
this seems fine to me, also see #33 and specifically metadata/rpm/5.5.0/metadata.inc file which is how I envision this working for RPMs. can we align the locations / concept and metadata itself? other question is why do we need 3 control files, did you envision 3 packages? |
Yes, I expect at least 3 packages initially, with more in the future (architecture variants). |
@tomerd, there are a number of fundamental flaws in this PR all of which highlight the need for a package design document as we discussed in #27. package naming ?The package naming was commented on in a code review by @stevapple but for some reason this has been ignored. package descriptionsThe package descriptions for the different versions are a bit strange - 3 levels of swift install ?The inclusion of multiple control files for different levels of swift install I feel is unnecessary at this point in time. There has been no discussion about different levels of install packages i.e. swift-runtime, swift-?, swift-dev. master control file templateThere will be a need for many control files for all the different distributions supported but these will essentially be identical and can generated from a master control file template. missing metadataThis PR does not represent a working control file and is also not usable as a template as there are a number of missing and essential fields. WIPI know that this is all work in progress but if we don't start in the right place then this whole process will be a time consuming mess and we will never achieve the desired outcome. |
hi @futurejones inline
I agree and @shahmishal is putting one together. this repo is in a work-in-progress state and no packages are to be created from it until we finalize the design questions you highlight.
totally agree, and I also put out #33 which attempts to start the unification process from a technical side of things, with the actual content pending the design mentioned above
agree - lets discuss this more when @shahmishal puts the design doc PR out
agree - lets discuss this more when @shahmishal puts the design doc PR out
agree - lets discuss this more when @shahmishal puts the design doc PR out. fwiw I imagined two kind (one for development - full toolchain, and one for runtime - just runtime support libraries) and looks like @compnerd has 3 in mind, we should hash this out more in the design phase
not familiar enough with debian control files, but we should discuss more
agree - lets discuss this more when @shahmishal puts the design doc PR out
agree again, I think the next step here is for @shahmishal to puts the design doc PR out. |
What is the status of this PR? We merged the Debs package control files already. |
I don't think that this is needed anymore then. I think that it got held up and people just redid the work 🤷♂️ |
The packaging on debian mostly requires the control files and a
pre-configured layout to package as a root. This adds the control files
as a starting point.