Skip to content

Add PackageModelSyntax.dll #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2024
Merged

Add PackageModelSyntax.dll #284

merged 1 commit into from
Apr 27, 2024

Conversation

hjyamauchi
Copy link
Contributor

@hjyamauchi
Copy link
Contributor Author

CC @compnerd

@hjyamauchi
Copy link
Contributor Author

CC @DougGregor This should fix the issue with spm failing to run installed from the windows installer

@hjyamauchi
Copy link
Contributor Author

Oops the diff isn't correct. Fixing

@hjyamauchi
Copy link
Contributor Author

Fixed. Ready for review

@compnerd compnerd mentioned this pull request Apr 26, 2024
Open
DougGregor
DougGregor approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great

@compnerd compnerd merged commit 56d9158 into swiftlang:main Apr 27, 2024
@compnerd
Copy link
Member

@DougGregor I assume that this doesn't need to be pulled into release/6.0? Or should we get this cherry-picked?

@DougGregor
Copy link
Member

We do need this on 6.0; I've opened a cherry-pick at #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@DougGregor DougGregor DougGregor approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjyamauchi @compnerd @DougGregor