improve docker setup #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
fix/docker-setup
branch
5 times, most recently
from
5abc83b to
ca61412
Compare
motivation: make it easier to run the build changes: * use docker-compose to orchestrate the build * udpate docker file to only be focused on basic build requirments * expand build_rpm.sh to do the build end-to-end * update readme with details on how to use the new setup
tomerd
force-pushed
the
fix/docker-setup
branch
from
ca61412 to
1cbaf17
Compare
|
LGTM! Thanks @tomerd. Can we also do this for Fedora? so it's consistent between platforms. |
yes happy to. @tachoknight are you good with that? |
Sure, I'll make the changes and submit a PR. |
|
This will break CI |
|
Reverting this PR because it broke CI. @tomerd let's coordinate with CI changes before merging this PR. |
shahmishal
added a commit
that referenced
this pull request
Oct 8, 2021
This reverts commit 14238eb.
|
sorry about that @shahmishal. would fixing CI be an option? since this is not actually breaking anything production maybe we can fix forward rather than reverting, which will allow us to make progress with adopting this for other specs? ci would need to be changed to do the following: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: make it easier to run the build
changes: