[6.0] Rewrite test-sourcekit-lsp.py to not rely on --sync option in sourcekit-lsp
#135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stderr contains log output from sourcekit-lsp but we want to match the LSP communication that happens over stdin/stdout. It seems that the additional stderr output can confuse `FileCheck`. rdar://125139888
…ekit-lsp The `test-sourcekit-lsp` integration test sent all requests to `sourcekit-lsp` via stdin in one go and relies on the `--sync` option in sourcekit-lsp to handle one request at a time. It closes `stdin` when it reaches the end of the data it wants to send to sourcekit-lsp. With the refactored `JSONRPCConnection` implementation, this caused us to immediately close the connection, without waiting for any outstanding replies to be sent. Rewrite `test-sourcekit-lsp.py` to actually wait for the request results. This also allows us to delete the `--sync` option of sourcekit-lsp and test a configuration of sourcekit-lsp that is a lot closer to what actual users are going to use.
…st reply If sourcekit-lsp sent a `publishDiagnostics` notification, we would try to interpret it as a request reply. This failed because the notification wasn’t actually the reply to the request we were expecting. Ignore all notifications or requests from sourcekit-lsp when waiting for a request reply to fix this issue.
bnbarham
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-sourcekit-lspintegration test sent all requests tosourcekit-lspvia stdin in one go and relies on the--syncoption in sourcekit-lsp to handle one request at a time. It closesstdinwhen it reaches the end of the data it wants to send to sourcekit-lsp. With the refactoredJSONRPCConnectionimplementation, this caused us to immediately close the connection, without waiting for any outstanding replies to be sent.Rewrite
test-sourcekit-lsp.pyto actually wait for the request results. This also allows us to delete the--syncoption of sourcekit-lsp and test a configuration of sourcekit-lsp that is a lot closer to what actual users are going to use.Also include the bug fix of Ignore notifications sent from sourcekit-lsp when waiting for a request reply #134
test-sourcekit-lsp.pyintegration testrelease/6.0is equivalent tomain