Address concurrency warnings (#7964)

Fix the rest of the concurrency warnings caused by directly passing a
continuation's resume method.

Follow on to #7961

Author: plemarquand

Sources/Basics/Concurrency/AsyncProcess.swift

@@ -786,7 +786,9 @@ package final class AsyncProcess {
     package func waitUntilExit() async throws -> AsyncProcessResult {
         try await withCheckedThrowingContinuation { continuation in
             DispatchQueue.processConcurrent.async {
-                self.waitUntilExit(continuation.resume(with:))
+                self.waitUntilExit({
+                    continuation.resume(with: $0)
+                })
             }
         }
     }

Sources/PackageCollections/Storage/SQLitePackageCollectionsStorage.swift

@@ -625,7 +625,7 @@ final class SQLitePackageCollectionsStorage: PackageCollectionsStorage, Closable
             try self.withDB { db in
                 let packagesStatement = try db.prepare(query: "INSERT INTO \(Self.packagesFTSName) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?);")
                 let targetsStatement = try db.prepare(query: "INSERT INTO \(Self.targetsFTSNameV1) VALUES (?, ?, ?, ?);")
-                
+
                 try db.exec(query: "BEGIN TRANSACTION;")
                 do {
                     // Then insert new data
@@ -679,7 +679,7 @@ final class SQLitePackageCollectionsStorage: PackageCollectionsStorage, Closable
                             try targetsStatement.reset()
                         }
                     }
-                    
+
                     try db.exec(query: "COMMIT;")
                 } catch {
                     try db.exec(query: "ROLLBACK;")
@@ -728,7 +728,11 @@ final class SQLitePackageCollectionsStorage: PackageCollectionsStorage, Closable
         }
     }
     internal func populateTargetTrie() async throws {
-        try await withCheckedThrowingContinuation { self.populateTargetTrie(callback: $0.resume(with:)) }
+        try await withCheckedThrowingContinuation { continuation in
+            self.populateTargetTrie(callback: {
+                continuation.resume(with: $0)
+            })
+        }
     }
 
     internal func populateTargetTrie(callback: @escaping (Result<Void, Error>) -> Void = { _ in }) {
@@ -948,7 +952,7 @@ final class SQLitePackageCollectionsStorage: PackageCollectionsStorage, Closable
                 );
             """
             try db.exec(query: ftsTargetsV0)
-            
+
             let ftsTargetsV1 = """
                 CREATE VIRTUAL TABLE IF NOT EXISTS \(Self.targetsFTSNameV1) USING fts4(
                     collection_id_blob_base64, package_id, package_repository_url, name,

Sources/PackageGraph/PackageContainer.swift

@@ -189,13 +189,16 @@ public extension PackageContainerProvider {
         observabilityScope: ObservabilityScope,
         on queue: DispatchQueue
     ) async throws -> PackageContainer {
-        try await withCheckedThrowingContinuation {
+        try await withCheckedThrowingContinuation { continuation in
             self.getContainer(
                 for: package,
                 updateStrategy: updateStrategy,
                 observabilityScope: observabilityScope,
                 on: queue,
-                completion: $0.resume(with:))
+                completion: {
+                    continuation.resume(with: $0)
+                }
+            )
         }
     }
 }

Sources/PackageGraph/Resolution/PubGrub/PubGrubDependencyResolver.swift

@@ -252,10 +252,12 @@ public struct PubGrubDependencyResolver {
             }
 
             let products = assignment.term.node.productFilter
-            let container = try await withCheckedThrowingContinuation {
+            let container = try await withCheckedThrowingContinuation { continuation in
                 self.provider.getContainer(
                     for: assignment.term.node.package,
-                    completion: $0.resume(with:)
+                    completion: {
+                        continuation.resume(with: $0)
+                    }
                 )
             }
             let updatePackage = try await container.underlying.loadPackageReference(at: boundVersion)
@@ -278,8 +280,10 @@ public struct PubGrubDependencyResolver {
 
         // Add overridden packages to the result.
         for (package, override) in state.overriddenPackages {
-            let container = try await withCheckedThrowingContinuation {
-                self.provider.getContainer(for: package, completion: $0.resume(with:))
+            let container = try await withCheckedThrowingContinuation { continuation in
+                self.provider.getContainer(for: package, completion: {
+                    continuation.resume(with: $0)
+                })
             }
             let updatePackage = try await container.underlying.loadPackageReference(at: override.version)
             finalAssignments.append(.init(
@@ -340,10 +344,12 @@ public struct PubGrubDependencyResolver {
                 // We collect all version-based dependencies in a separate structure so they can
                 // be process at the end. This allows us to override them when there is a non-version
                 // based (unversioned/branch-based) constraint present in the graph.
-                let container = try await withCheckedThrowingContinuation {
+                let container = try await withCheckedThrowingContinuation { continuation in
                     self.provider.getContainer(
                         for: node.package,
-                        completion: $0.resume(with:)
+                        completion: {
+                            continuation.resume(with: $0)
+                        }
                     )
                 }
                 for dependency in try await container.underlying
@@ -394,8 +400,10 @@ public struct PubGrubDependencyResolver {
 
             // Process dependencies of this package, similar to the first phase but branch-based dependencies
             // are not allowed to contain local/unversioned packages.
-            let container = try await withCheckedThrowingContinuation {
-                self.provider.getContainer(for: package, completion: $0.resume(with:))
+            let container = try await withCheckedThrowingContinuation { continuation in
+                self.provider.getContainer(for: package, completion: {
+                    continuation.resume(with: $0)
+                })
             }
 
             // If there is a pin for this revision-based dependency, get
@@ -676,7 +684,9 @@ public struct PubGrubDependencyResolver {
             for term in terms {
                 group.addTask {
                     let container = try await withCheckedThrowingContinuation { continuation in
-                        self.provider.getContainer(for: term.node.package, completion: continuation.resume(with:))
+                        self.provider.getContainer(for: term.node.package, completion: {
+                            continuation.resume(with: $0)
+                        })
                     }
                     return try await (term, container.versionCount(term.requirement))
                 }

Sources/PackageRegistry/ChecksumTOFU.swift

@@ -46,7 +46,7 @@ struct PackageVersionChecksumTOFU {
         observabilityScope: ObservabilityScope,
         callbackQueue: DispatchQueue
     ) async throws {
-        try await withCheckedThrowingContinuation {
+        try await withCheckedThrowingContinuation { continuation in
             self.validateSourceArchive(
                 registry: registry,
                 package: package,
@@ -55,11 +55,13 @@ struct PackageVersionChecksumTOFU {
                 timeout: timeout,
                 observabilityScope: observabilityScope,
                 callbackQueue: callbackQueue,
-                completion: $0.resume(with:)
+                completion: {
+                    continuation.resume(with: $0)
+                }
             )
         }
     }
-    
+
     @available(*, noasync, message: "Use the async alternative")
     func validateSourceArchive(
         registry: Registry,