ManifestLoader.swift: Address concurrency warning #7961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManifestLoaderProtocol.load was forwarding a checked continuation's resume method directily as a completion handler, resulting in the warning: ``` converting a value of type '(__shared sending Result<Manifest, any Error>) -> ()' to type '(Result<Manifest, any Error>) -> Void' risks causing data races; this is an error in the Swift 6 language mode ```
plemarquand
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca and
owenv
as code owners
xedin
approved these changes
Sep 12, 2024
|
@swift-ci please test |
|
Windows failure: |
|
@swift-ci please test Windows platform |
MaxDesiatov
approved these changes
Sep 13, 2024
plemarquand
added a commit
to plemarquand/swift-package-manager
that referenced
this pull request
Sep 13, 2024
Fixes up a few different types of warnings in the tests: - Unused variables are replaced with `_` - Continuation handlers are not passed through directly (follows on from swiftlang#7961) - Removes unnecessary `await`s from functions that are now synchronous
plemarquand
added a commit
to plemarquand/swift-package-manager
that referenced
this pull request
Sep 13, 2024
Fix the rest of the concurrency warnings caused by directly passing a continuation's resume method. Follow on to swiftlang#7961
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 13, 2024
Fix the rest of the concurrency warnings caused by directly passing a continuation's resume method. Follow on to #7961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManifestLoaderProtocol.load was forwarding a checked continuation's resume method directily as a completion handler, resulting in the warning: