Not enough info in the warning about conflicting repos #8311
Labels
Comments
|
I also think this warning is a bit half baked. IIRC, the purpose was to help with registry migration, but e.g. in this particular case, both URLs point to the literal same repo, so it feels like we should be able to not even emit a warning. |
bripeticca
pushed a commit
that referenced
this issue
Mar 25, 2025
Update error messaging to be a bit more clear where the conflict of identities is coming from. ### Motivation: #8311 — when multiple packages share the same identity (for example: `gh/swiftlang/swift-driver` and `gh/apple/swift-driver` share the same identity `swift-driver`) then the error doesn't help to resolve the conflict. It is particularly confusing when the conflicting package is pulled from transitive dependencies. I wanted to offer more context to resolve these types of conflicts, particularly: - how the conflict is introduced in relation to the root package - itemize all paths for both sides of the conflict, so that users can better understand how to approach resolution, but not overwhelm the error message with too many details ### Modifications: - Rephrase error message for clarity, add a suggestion to work with maintainers of transitive dependencies. - Reconstruct the dependency chains from roots to the conflicting packages. ### Result: Before: `'swift-build': 'swift-build' dependency on 'https://github.com/swiftlang/swift-driver.git' conflicts with dependency on 'https://github.com/apple/swift-driver.git' which has the same identity 'swift-driver'.` After: `Conflicting identity for swift-driver: dependency 'github.com/swiftlang/swift-driver' and dependency 'github.com/apple/swift-driver' both point to the same package identity 'swift-driver'. The dependencies are introduced through the following chains: (A) /users/yy/pub/swift-package-manager->github.com/swiftlang/swift-build->github.com/swiftlang/swift-driver (B) /users/yy/pub/swift-package-manager->github.com/apple/swift-driver. If there are multiple chains that lead to the same dependency, only the first chain is shown here. To see all chains use debug output option. To resolve the conflict, coordinate with the maintainer of the package that introduces the conflicting dependency. ` Plus also debug logs: `debug: 'swift-build': Conflicting identity for swift-driver: chains of dependencies for https://github.com/swiftlang/swift-driver.git: [[/users/yy/pub/swift-package-manager, github.com/swiftlang/swift-build, github.com/swiftlang/swift-driver]]` `debug: 'swift-build': Conflicting identity for swift-driver: chains of dependencies for https://github.com/apple/swift-driver.git: [[/users/yy/pub/swift-package-manager, github.com/apple/swift-driver]]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is it reproducible with SwiftPM command-line tools:
swift build,swift test,swift packageetc?swift build,swift test,swift packageetc.Description
I am getting this warning from SwiftPM as I resolve the dependencies in our PR that add the dependency on swift-build.
warning: 'swift-build': 'swift-build' dependency on 'https://github.com/swiftlang/swift-driver.git' conflicts with dependency on 'https://github.com/apple/swift-driver.git' which has the same identity 'swift-driver'. this will be escalated to an error in future versions of SwiftPM.
It's good that it's telling me one side of the story. The question is where is the dependency on the 'apple' version of the URL coming from? It's not from SwiftPM since we don't have a direct dependency on swift-driver.
Expected behavior
No response
Actual behavior
No response
Steps to reproduce
From a clone of SwiftPM, fetch the PR with the new swift-build dependency in it.
Then do a
swift build. You should see the warningSwift Package Manager version/commit hash
Latest main toolchain
Swift & OS version (output of
swift --version ; uname -a)No response
The text was updated successfully, but these errors were encountered: