Clean up options and flags for package, build, and test subcommands
#370
Conversation
This cleans up the options that the new `package` and the old `build` and `test` subcommands take. Things had become ugly after implementing SE-0085.
| @@ -37,11 +37,11 @@ private enum Mode: Argument, Equatable, CustomStringConvertible { | |||
|
|
|||
| init?(argument: String, pop: () -> String?) throws { | |||
| switch argument { | |||
| case "--configuration", "--conf", "-c": | |||
| case "--configuration", "--config": | |||
There was a problem hiding this comment.
I'm not sure if we should drop -c just yet, I think people and scripts are likely to rely on it.
There was a problem hiding this comment.
Ok, I've added it back. There is perhaps a broader conversation to be had about whether we in general support old-style single-dash/single-char short forms or just the double-dash/whole-word forms. I've looked at various tools for example and they seem all over the map about this, and not just the ancient ones either.
But we certainly don't want to break anything, so I've added it back.
|
Thanks for all the comments — I'm preparing another iteration of the PR. |
| case generateXcodeproj(String?) | ||
| case dumpPackage(String?) | ||
| case generateXcodeproj | ||
| case dumpPackage | ||
|
|
||
| init?(argument: String, pop: () -> String?) throws { | ||
| switch argument { | ||
| case "init", "initialize": |
There was a problem hiding this comment.
Do we want to get rid of initialize here? Seems wasteful.
|
I think I've addressed all the feedback. So far I haven't seen any dissent to the email I sent earlier, so I think we're converging. |
|
LGTM |
a supported abbreviation of -h).
order in which they're listed (internally only; the help is unaffected, since that order has been carefully chosen for user interface purposes).
|
LGTM |
|
Great, thanks for the reviews and comments. I'm merging this now. |
Clean up options and flags for `package`, `build`, and `test` subcommands
Changes for https://bugs.swift.org/browse/SR-1605
This cleans up the options that the new
packageand the oldbuildand
testsubcommands take. Things had become ugly after implementingSE-0085.