Revert "Initial implementation of Command Plugins" #3886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3af7f89.
compnerd
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
@compnerd Is there a log where I can see how this failed? It should be possible to fix this forward. |
|
@abertelrud @compnerd is this addressed by #3888 and can be close? |
|
@tomerd - I want to keep this open until we know that it does fix the build, otherwise, I think that we should roll back to get the builds green again - they have been broken for ~12 hours now. |
In my view we can close this, since I'm confident that we can fix this forward. We are still testing #3888 but I don't see a circumstance in which we'd need to revert this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3855