Fix a crash if a checkout has no a manifest #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should indeed add a fixture for this. I can do it later unless you are keen. |
|
I'd like to do it to familiarise myself a bit with the test suite :) |
|
I added a new file for the test, because the only Git-related ones seemed to be part of the |
|
Rebased & merged: f86f87b |
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
<rdar://problem/28676638> Need BuildSystem support for build cancellation
MaxDesiatov
pushed a commit
to MaxDesiatov/swift-package-manager
that referenced
this pull request
Jul 6, 2020
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will update the PR with a test case if this change is desirable. I'm not sure if it would be better to fail at an earlier stage.