move TOML printing to toTOML methods. #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every type should know how to TOML itself and don't expose it to others.
mxcl
added a commit
that referenced
this pull request
Dec 9, 2015
move TOML printing to toTOML methods.
|
I would enjoy reading the PR for |
|
Ok! 👍starting work on it |
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
…-test-on-linux Disable signal handling tests on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every type should know how to TOML itself and don't expose it to others.
I just moved correct implementation to
toTOML()methods for a type.I think it makes reading code much easier, because implementation details are hidden.
What do you think about it?
The next step I thought could be creating
TOMLableprotocol and conforming to it