Basics/Commands: add experimental CC SDK paths option #5879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
@swift-ci please smoke test |
neonichu
reviewed
Nov 4, 2022
neonichu
approved these changes
Nov 4, 2022
MaxDesiatov
changed the title
experimental-cc-sdks-path option
MaxDesiatov
force-pushed
the
maxd/cc-sdks-option
branch
from
0a7f8d3 to
b7389d1
Compare
MaxDesiatov
force-pushed
the
maxd/cc-sdks-option
branch
2 times, most recently
from
cab08c6 to
6a04b29
Compare
This reverts commit cf19c64 and restores the `--build-path` option. It also switches the `bootstrap` script back to using it so that we have an easy check that the option is still present.
neonichu
force-pushed
the
swift-bootstrap-cmd-3
branch
from
bc6b7de to
2c52312
Compare
MaxDesiatov
force-pushed
the
maxd/cc-sdks-option
branch
from
6a04b29 to
1b04522
Compare
…xd/cc-sdks-option # Conflicts: # Sources/CoreCommands/Options.swift # Sources/CoreCommands/SwiftTool.swift
|
@swift-ci please smoke test |
tomerd
reviewed
Nov 10, 2022
tomerd
approved these changes
Nov 10, 2022
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The experimental option doesn't do anything yet, but this PR lays some groundwork for cross-compilation SDK bundles support.
Modifications:
Extended
FileSystemto support newsdkssubdirectory of eitheridiomaticSwiftPMDirectoryordotSwiftPMdirectories. Added new option toLocationOptions.Result:
--experimental-cc-sdks-pathoption can be passed a path to a directory with cross-compilation SDK bundles. The option is hidden and as of this PR has no effect whatsoever.