[5.8] Add package metadata to a few more ObservabilityScopes in workspace-wide package operations #5986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide and package graph loading operations (swiftlang#5984) Clients of libSwiftPM that present diagnostics use the package metadata that can optionally be attached to an emitted Diagnostic to associate it with the package in the user interface. This change addresses a few more cases in which no package metadata was associated. Where possible, the metadata is associated with the ObservabilityScope at the highest place in the call stack so that any diagnostic emitted below it gets the package metadata. rdar://103561534 (cherry picked from commit 723a592)
|
@swift-ci please smoke test |
tomerd
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftPM 5.8 nomination of #5984.
rdar://103561534
(cherry picked from commit 723a592)