Skip to content

[5.9] Add publication time to registry package release metadata #6413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yim-lee
Copy link
Contributor

@yim-lee yim-lee commented Apr 11, 2023

Cherry-pick #6407 to 5.9

…6407)

* Add publication time to registry package release metadata

Motivation:
Registry should have information about how a package was published. This includes who published it, who signed it, and when it was published.
 - "Who published the package release?": this is `metadata.author`, which is already defined in the metadata JSON schema.
 - "Who signed the package release?": this can be extracted from the signing certificate if signed (requires rdar://107483043 and will be done in separate PR)
 - "When was the release published?": added in this PR

rdar://106674475

Modifications:
- Add `originalPublicationTime` to user-provided metadata during publication
- Add `publishedAt` to registry's package release metadata response
- Update registry API spec

* Add publishedAt to PackageSearchClient
@yim-lee yim-lee added the swift 5.9 This PR targets the 5.9 branch label Apr 11, 2023
@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 11, 2023

@swift-ci please smoke test

@yim-lee
Copy link
Contributor Author

yim-lee commented Apr 11, 2023

@swift-ci please test Windows platform

@yim-lee yim-lee merged commit 15d82c3 into swiftlang:release/5.9 Apr 12, 2023
@yim-lee yim-lee deleted the registry-version-publishedat-5.9 branch April 12, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
swift 5.9 This PR targets the 5.9 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants