Integration with swift-testing #7047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
tomerd
reviewed
Oct 31, 2023
tomerd
reviewed
Oct 31, 2023
tomerd
reviewed
Oct 31, 2023
tomerd
reviewed
Oct 31, 2023
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
@swift-ci please test |
|
@swift-ci please test Windows |
grynspan
force-pushed
the
jgrynspan/swift-testing-integration
branch
from
170b023 to
2fe0bbb
Compare
|
@swift-ci please test |
neonichu
approved these changes
Nov 1, 2023
|
@swift-ci please test windows |
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please test |
|
@swift-ci please test Windows |
1 similar comment
|
@swift-ci please test Windows |
tomerd
reviewed
Nov 2, 2023
|
@swift-ci please test |
|
@swift-ci please test Windows |
3 similar comments
|
@swift-ci please test Windows |
|
@swift-ci please test Windows |
|
@swift-ci please test Windows |
MaxDesiatov
reviewed
Nov 5, 2023
grynspan
force-pushed
the
jgrynspan/swift-testing-integration
branch
from
ccda01c to
b480d3c
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
grynspan
force-pushed
the
jgrynspan/swift-testing-integration
branch
from
971f0d5 to
f0e2a05
Compare
|
@swift-ci please test |
|
@swift-ci test windows |
grynspan
force-pushed
the
jgrynspan/swift-testing-integration
branch
from
f0e2a05 to
014d8be
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please test |
|
@swift-ci please test Windows |
grynspan
force-pushed
the
jgrynspan/swift-testing-integration
branch
from
014d8be to
07fdd30
Compare
This PR sets up initial integration with swift-testing. It plumbs through the concept of "testing library" from `SwiftTestTool` down to `BuildOperationBuildSystemDelegateHandler`. Developers can opt into support for swift-testing by passing `--enable-experimental-swift-testing`. This causes the package manager to perform a _separate_ build of applicable test targets using swift-testing instead of XCTest. If XCTest remains enabled (i.e. by not also explicitly passing `--disable-xctest`), then tests from both libraries can be run. At build time, the package manager will now (when opted in) synthesize a main function for the binary that calls a known entry point function in swift-testing. On Darwin, the build flow for XCTest-based tests differs from that on Linux (corelibs-xctest); swift-testing's build flow is very similar to the corelibs-xctest flow and uses most of the same circuitry. A future area of exploration for us may be to adopt this flow even when using XCTest on Darwin, but it's not in the scope of our work right now. swift-testing is responsible for interpreting any additional arguments passed to it such as `--filter`; this support has not been implemented yet and will be built up over time.
grynspan
force-pushed
the
jgrynspan/swift-testing-integration
branch
from
07fdd30 to
00f0359
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
@swift-ci please test windows |
|
@swift-ci please test macOS |
1 similar comment
|
@swift-ci please test macOS |
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Nov 21, 2023
We now have functional support for swift-testing in Swift Package Manager (as of swiftlang/swift-package-manager#7047). We should update our documentation: - Point developers to the main branch instead of 5.10 again; - Show developers how to invoke `swift test` in a way that triggers swift-testing; and - Show developers how to use `XCTestScaffold` _only_ when using an older toolchain (with the appropriate caveats and nuances emphasized.) Resolves #126.
2 tasks
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Nov 27, 2023
* Update Getting Started docs to use Swift main branch features We now have functional support for swift-testing in Swift Package Manager (as of swiftlang/swift-package-manager#7047). We should update our documentation: - Point developers to the main branch instead of 5.10 again; - Show developers how to invoke `swift test` in a way that triggers swift-testing; and - Show developers how to use `XCTestScaffold` _only_ when using an older toolchain (with the appropriate caveats and nuances emphasized.) Resolves #126.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up initial integration with swift-testing. It plumbs through the concept of "testing library" from
SwiftTestTooldown toBuildOperationBuildSystemDelegateHandler.Developers can opt into support for swift-testing by passing
--enable-experimental-swift-testing. This causes the package manager to perform a separate build of applicable test targets using swift-testing instead of XCTest. If XCTest remains enabled (i.e. by not also explicitly passing--disable-xctest), then tests from both libraries can be run.At build time, the package manager will now (when opted in) synthesize a main function for the binary that calls a known entry point function in swift-testing. On Darwin, the build flow for XCTest-based tests differs from that on Linux (corelibs-xctest); swift-testing's build flow is very similar to the corelibs-xctest flow and uses most of the same circuitry. A future area of exploration for us may be to adopt this flow even when using XCTest on Darwin, but it's not in the scope of our work right now.
swift-testing is responsible for interpreting any additional arguments passed to it such as
--filter; this support has not been implemented yet and will be built up over time.Example command to trigger running swift-testing's self-hosted tests (prior to an updated toolchain):
Resolves #7027.
Resolves rdar://114997435.