Async package registry tests #7135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_await Add async alternatives to PackageSigningEntityStorage Mark non-async methods noasync Improve the fixture method to return the result of the body
AndrewHoos
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
jakepetroules
approved these changes
Nov 29, 2023
|
@swift-ci please test |
Add async alternatives Leave a note on why the last temp_await is not removed
AndrewHoos
force-pushed
the
async-PackageRegistryTests
branch
from
789f1ed to
44506bb
Compare
|
@swift-ci please test |
|
@swift-ci test windows |
MaxDesiatov
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move PackageRegistryTests to async/await
Motivation:
To keep moving things from temp_await to actual await
Modifications:
Add async alternatives to registry methods
Mark non-async methods noasync to encourage migration
Result:
All, but one use of temp_await is removed from the tests