-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix macro template #7281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macro template #7281
Conversation
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything that was broken by the lack of this line? If this code didn't compile, couldn't we detect it with an end-to-end test that runs package init
with this template and then swift build
?
Yes, we were generating the
In theory yes, in practice we cannot end-to-end test macros today because we can't download swift-syntax on CI and we also don't have all the necessary components in the toolchain to attempt to use that as a replacement. |
|
@swift-ci please test linux |
Looks like macOS self-hosted is also hanging? |
My guess would be that it's related to #7269? |
Actually, all tests should have individual scratch directories, so it doesn't seem super likely for this to be the cause. Can't repro locally, either. |
@swift-ci please test linux |
@swift-ci please test macOS |
No description provided.