[6.0] Suppress warnings for remote Clang targets #7456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
added
build system
|
@swift-ci please test |
bnbarham
approved these changes
Apr 13, 2024
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
MaxDesiatov
approved these changes
Apr 13, 2024
We need this information to set `-w` and other package specific options. (cherry picked from commit c86ea69)
This mirrors behavior of remote swift targets which suppress warnings as well. (cherry picked from commit 398dab8)
Remote in this case means local or remote source control or registry. (cherry picked from commit 08efdf5)
xedin
force-pushed
the
suppress-warnings-for-remote-clang-targets-6.0
branch
from
71af9c8 to
857b268
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors behavior of remote swift targets which suppress warnings as well. Remote package warnings are generally not addressible anyway at the moment.
Scope: Remote class targets.
Main Branch PRs: Suppress warnings for remote Clang targets #7423
Risk: Very Low
Reviewed By: @bnbarham @MaxDesiatov
Testing: Added test-cases to the test suite.