Add basic thresholds for PackageGraphBenchmarks.swift
#7462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This records thresholds for two relatively stable metrics: total malloc count and total number of syscalls. We don't run these benchmarks on CI yet, but now it allows tracking regressions locally.
MaxDesiatov
added
no functional change
|
@swift-ci test |
MaxDesiatov
commented
Apr 16, 2024
MaxDesiatov
commented
Apr 16, 2024
MaxDesiatov
commented
Apr 16, 2024
| Benchmark( | ||
| "Package graph loading", | ||
| "PackageGraphLoading", |
There was a problem hiding this comment.
Working around a known package-benchmark issue with whitespace handling in benchmark names when reading recorded thresholds.
|
@swift-ci test |
bnbarham
approved these changes
Apr 16, 2024
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test windows |
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
This records thresholds for two relatively stable metrics: total malloc count and total number of syscalls. We don't run these benchmarks on CI yet, but now it allows tracking regressions locally.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
This records thresholds for two relatively stable metrics: total malloc count and total number of syscalls. We don't run these benchmarks on CI yet, but now it allows tracking regressions locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This records thresholds for two relatively stable metrics: total malloc count and total number of syscalls. We don't run these benchmarks on CI yet, but now it allows tracking regressions locally.