swift sdk: print warnings on stderr instead of stdout
#7532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tools and scripts may rely on command output to remain parseable, so printing these warnings on `stdout` can break such scripts. We should output these warnings on `stderr` instead. As these warnings are emitted before any logging is available, we're using `fputs` for output on `stderr`
|
@swift-ci test |
bnbarham
approved these changes
May 8, 2024
MaxDesiatov
added a commit
that referenced
this pull request
May 8, 2024
Cherry-pick of #7532. **Explanation**: Tools and scripts may rely on command output to remain parseable, so printing these warnings on `stdout` can break such workflows. We should output these warnings on `stderr` instead. As these warnings are emitted before any logging is available, we're using `fputs` for output on `stderr` **Scope**: Isolated to `swift sdk` command and subcommands. **Risk**: Low, the actual change is only 4 lines touching `print` and `import`, code coverage for those is present. **Testing**: End-to-end test cases present in `Tests/CommandsTests/SDKCommandTests.swift` **Issue**: N/A **Reviewer**: @bnbarham
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
Tools and scripts may rely on command output to remain parseable, so printing these warnings on `stdout` can break such workflows. We should output these warnings on `stderr` instead. As these warnings are emitted before any logging is available, we're using `fputs` for output on `stderr`
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
Tools and scripts may rely on command output to remain parseable, so printing these warnings on `stdout` can break such workflows. We should output these warnings on `stderr` instead. As these warnings are emitted before any logging is available, we're using `fputs` for output on `stderr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools and scripts may rely on command output to remain parseable, so printing these warnings on
stdoutcan break such workflows. We should output these warnings onstderrinstead.As these warnings are emitted before any logging is available, we're using
fputsfor output onstderr