[PackageModel] Associated swift version build setting with `SWIFT_VER… #7550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
MaxDesiatov
approved these changes
May 10, 2024
jakepetroules
requested changes
May 10, 2024
Sources/Build/BuildDescription/SwiftTargetBuildDescription.swift
Outdated
Show resolved
Hide resolved
…SION` declaration Instead of putting it into `OTHER_SWIFT_FLAGS`, let's introduce a dedicated declaration scope - `SWIFT_VERSION` to ease handling and discovery. Resolves: rdar://127883018
xedin
force-pushed
the
move-swift-version-into-its-own-decl
branch
from
31660fb to
ef1f1a5
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
jakepetroules
approved these changes
May 10, 2024
xedin
added a commit
that referenced
this pull request
May 16, 2024
- Explanation:
Implementation of SE-0435 proposal.
Add a new Swift target setting API, similar to `enable{Upcoming,
Experimental}Feature`,
to specify a Swift language version that should be used to build the
target, if such
version is not specified, fallback to the current language version
determination logic.
- Scope: TargetDescription API and build system.
- Main Branch PRs:
#7439,
#7544,
#7550,
#7557
- Radar: rdar://125732014
- Risk: Low
- Reviewed By: @MaxDesiatov @bnbarham
- Testing: Added new test-cases to the test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…SION` declaration
Instead of putting it into
OTHER_SWIFT_FLAGS, let's introduce a dedicated declaration scope -SWIFT_VERSIONto ease handling and discovery.Resolves: rdar://127883018