Add two Sendable annotations to enable building SourceKit-LSP in Swift 6 mode
#7553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to build `SourceKitLSP` in Swift 6 mode.
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
This allows us to build `SourceKitLSP` in Swift 6 mode.
ahoppen
changed the title
FileRuleDescription as SendableSendable annotations to enable building SourceKit-LSP in Swift 6 mode
|
@swift-ci Please test |
|
@swift-ci Please test |
xedin
approved these changes
May 13, 2024
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…ift 6 mode (swiftlang#7553) - Mark `FileRuleDescription` as `Sendable` - Make `Platform` sendable and make `Platform.current` a constant
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…ift 6 mode (swiftlang#7553) - Mark `FileRuleDescription` as `Sendable` - Make `Platform` sendable and make `Platform.current` a constant
ahoppen
added a commit
that referenced
this pull request
May 15, 2024
…t 6 mode (#7559) * **Explanation**: Mark `FileRuleDescription` and `Platform` as `Sendable` and make `Platform.current` a constant. This allows us to build SourceKit-LSP in Swift 6 mode * **Scope**: `FileRuleDescription` and `Platform` if SwiftPM is used as a library * **Risk**: Very low, adding `Sendable` conformances is safe and I don’t expect anyone to modify `Platform.current` * **Testing**: Verified that this helps us build SourceKit-LSP in Swift 6 mode * **Issue**: n/a * **Reviewer**: @xedin on #7553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileRuleDescriptionasSendablePlatformsendable and makePlatform.currenta constant