[6.0][Basics] Switch IdentifiableSet to use OrderedDictionary
#7634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns `IdentifiableSet` into an ordered collection which should cut on flakiness in tests and other spots that expect certain ordering of elements. (cherry picked from commit b0afde9)
|
@swift-ci please test |
bnbarham
approved these changes
Jun 4, 2024
|
IIRC there was a test that was sorting because this wasn't sorting (that we can now remove). I ... do not remember it though 😅 @MaxDesiatov is your memory better than mine? |
|
@swift-ci please test Linux platform |
MaxDesiatov
added
bug
modules graph
xedin
changed the title
IdentifiableSet to use OrderedDictionaryIdentifiableSet to use OrderedDictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Turns
IdentifiableSetinto an ordered collection which should cut on flakiness in tests and other spots that expect certain ordering of elements.Scope: All uses of
IdentifiableSeti.e. package graph.Main Branch PR: [Basics] Switch
IdentifiableSetto useOrderedDictionary#7630Risk: Low
Reviewed By: @MaxDesiatov
Testing: No tests since the change is somewhat NFC.
(cherry picked from commit b0afde9)