[NFC] Rename SPMTestSupport to _InternalTestSupport
#7676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no such product or entity as "SPM", this contraction is just as invalid as "MOS" would be for macOS, or "SNIO" for SwiftNIO. All marketing and documentation materials consistently refer to it as "SwiftPM", and we should stay consistent in our codebase too. This also simplifies code search, as anything named as "SPM" almost never shows up in results when searching globally for "SwiftPM". We're not using `SwiftPMTestSupport` name here, as it might mislead contributors into thinking this module is somehow related to the `swift test` command. This module is purely internal, used only in modules with unit tests for SwiftPM itself, and is not supposed to be used by any packages depending on SwiftPM. Thus all `@_spi` declarations in it were also changed to `package`.
MaxDesiatov
added
the
no functional change
|
@swift-ci test |
MaxDesiatov
force-pushed
the
maxd/internal-test-support
branch
from
d212230 to
2eb73b9
Compare
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
changed the title
SPMTestSupport to InternalTestSupportSPMTestSupport to _InternalTestSupport
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
changed the title
SPMTestSupport to _InternalTestSupportSPMTestSupport to _InternalTestSupport
xedin
approved these changes
Jun 26, 2024
…xd/internal-test-support # Conflicts: # Sources/SPMTestSupport/ResolvedTarget+Mock.swift # Sources/_InternalTestSupport/ResolvedModule+Mock.swift # Sources/_InternalTestSupport/ResolvedTarget+Mock.swift # Tests/FunctionalPerformanceTests/BuildPerfTests.swift # Tests/FunctionalTests/ModuleMapTests.swift
|
@swift-ci test |
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no such product or entity as "SPM", this contraction is just as invalid as "MOS" would be for macOS, or "SNIO" for SwiftNIO. All marketing and documentation materials consistently refer to it as "SwiftPM", and we should stay consistent in our codebase too. This also simplifies code search, as anything named as "SPM" almost never shows up in results when searching globally for "SwiftPM".
We're not using
SwiftPMTestSupportname here, as it might mislead contributors into thinking this module is somehow related to theswift testcommand. This module is purely internal, used only in modules with unit tests for SwiftPM itself, and is not supposed to be used by any packages depending on SwiftPM. Thus all@_spideclarations in it were also changed topackage.