NFC: Assert that we don't add llbuild commands with the same name twice #7698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
kateinoigakukun
force-pushed
the
katei/assert-llbuild-cmd-name-conflict
branch
from
8c19aeb to
32bc365
Compare
|
@swift-ci test |
|
Out of curiosity does this catch any current bugs? |
|
Fortunately, the current SwiftPM test suites didn't detect any bugs 😺 |
|
@swift-ci test Windows |
xedin
approved these changes
Jun 24, 2024
kateinoigakukun
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add debug assertion to avoid llbuild command name conflicts.
Depends on #7695
Motivation:
One of the reasons we couldn't reveal #7695 issue for long time (at least past 2 releases) is that we overlooked name conflicts on
addWriteLinkFileListCommand.Looking into the manifest builder, some of the commands also forgot to assert name conflicts, so it was error-prone.
Modifications:
Add a convenience method to perform assertions consistently
Result:
NFC for release build. Just add debug assertions