Work around swift-bootstrap inability to handle plugins
#7750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bacb85a)
MaxDesiatov
added
bug
build system
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci test |
bnbarham
reviewed
Jul 3, 2024
MaxDesiatov
commented
Jul 3, 2024
|
@swift-ci test |
|
@swift-ci test windows |
xedin
approved these changes
Jul 3, 2024
|
@swift-ci test linux |
MaxDesiatov
added a commit
that referenced
this pull request
Jul 4, 2024
Cherry-pick of #7750. **Explanation**: `swift-bootstrap` currently can't handle dependencies with plugins, which prevents us from bumping Swift Argument Parser to a newer version, which did add a dependency on a plugin. The easiest workaround is to exclude plugins from the modules graph only when building with `swift-bootstrap`. **Scope**: isolated to the `swift-bootstrap` command. **Risk**: low due to isolated scope and the NFC nature of the change for all non-bootstrap builds (which are all of the common builds, `swift-bootstrap` is only used to build SwiftPM itself). **Testing**: automated, `swift-bootstrap` is exercised in every CI build. **Issue**: rdar://118081439 **Reviewer**: @xedin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-bootstrapcurrently can't handle dependencies with plugins, which prevents us from bumping Swift Argument Parser to a newer version, which did add a dependency on a plugin. The easiest workaround is to exclude plugins from the modules graph only when building withswift-bootstrap.