Add the formalized Swift Testing event stream arguments to swift test.
#7768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `--configuration-path`, `--event-stream-output-path`, and `--event-stream-version` to `swift test`. For more information, see the Swift Testing API proposal [here](https://github.com/apple/swift-testing/blob/main/Documentation/Proposals/0002-json-abi.md).
grynspan
added
swift test
grynspan
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci please test |
|
See also swiftlang/swift-testing#479 |
2 tasks
bnbarham
approved these changes
Jul 11, 2024
| struct TestEventStreamOptions: ParsableArguments { | ||
| /// Legacy equivalent of ``configurationPath``. | ||
| @Option(name: .customLong("experimental-configuration-path"), | ||
| help: .private) |
There was a problem hiding this comment.
What's private vs hidden? Haven't seen private before 🤔
There was a problem hiding this comment.
Hidden means it still shows up in verbose help. Private means it is never shown in help.
| @@ -656,6 +677,10 @@ extension SwiftTestCommand { | |||
| @OptionGroup() | |||
| var testLibraryOptions: TestLibraryOptions | |||
|
|
|||
| /// Options for Swift Testing's event stream. | |||
| @OptionGroup() | |||
| var testEventStreamOptions: TestEventStreamOptions | |||
There was a problem hiding this comment.
Is this really for just configuration rather than the stream options?
There was a problem hiding this comment.
I don't understand, sorry?
There was a problem hiding this comment.
This is in list. Does list actually need all these, or does it just need the configuration path?
There was a problem hiding this comment.
list can use them all now! See swiftlang/swift-testing#511
grynspan
deleted the
jgrynspan/formalized-swift-testing-event-stream-args
branch
grynspan
added a commit
that referenced
this pull request
Jul 12, 2024
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Jul 12, 2024
This PR changes the behavior of `swift test list` and its various synonyms to allow reporting the list of tests via the ABI-stable JSON mechanism described in #479. As it is not currently possible to directly call `swift test list --event-stream-output-path ... --event-stream-version 0`, it's a bit hard to test this code. However, it is possible to opt into this mode using `--configuration-path` and passing a path to a JSON file that includes `"listTests": true` (as noted by @allevato.) Support for these arguments with `swift test list` is tracked by swiftlang/swift-package-manager#7768. Resolves #506. Resolves rdar://130627856. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--configuration-path,--event-stream-output-path, and--event-stream-versiontoswift test.For more information, see the Swift Testing API proposal here.