Detect when Swift Testing returns EXIT_NO_TESTS_FOUND.
#7777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR detects when a Swift Testing run returns `EXIT_NO_TESTS_FOUND` and treats it as a successful test run. This change handles the change from swiftlang/swift-testing#536. Separately, the refactor in #7766 stops Swift Package Manager from reporting `"No matching test cases were run"` when XCTest has no tests matching passed `--filter` arguments. A third PR after these two have been merged will restore that functionality by collating results from both XCTest and Swift Testing. This change partially resolves rdar://131704587.
grynspan
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci please test |
grynspan
commented
Jul 14, 2024
| success = success && testSuccess | ||
| results.append(testSuccess) | ||
| } | ||
| if results.contains(.failure) { |
There was a problem hiding this comment.
If anything failed, the run failed. If anything passed and had matching tests, the run passed. If everything reported no matching tests, then there were no matching tests.
grynspan
commented
Jul 14, 2024
|
|
||
| /// Executes and returns execution status. Prints test output on standard streams if requested | ||
| /// - Returns: Result of spawning and running the test process, and the output stream result | ||
| @_disfavoredOverload |
There was a problem hiding this comment.
Temporarily disfavored until #7766 is in the build in order to preserve the semantics of surrounding code, at which point the overload that returns a Bool can be removed.
grynspan
commented
Jul 14, 2024
| /// Because Swift Package Manager does not directly link to the testing library, | ||
| /// it duplicates the definition of this constant in its own source. Any changes | ||
| /// to this constant in either package must be mirrored in the other. | ||
| private var EXIT_NO_TESTS_FOUND: CInt { |
There was a problem hiding this comment.
Copied verbatim from Swift Testing's PR.
|
@swift-ci please test |
bnbarham
approved these changes
Jul 15, 2024
|
@swift-ci please test Windows |
grynspan
added a commit
that referenced
this pull request
Jul 16, 2024
This PR detects when a Swift Testing run returns `EXIT_NO_TESTS_FOUND` and treats it as a successful test run. This change handles the change from swiftlang/swift-testing#536. Separately, the refactor in #7766 stops Swift Package Manager from reporting `"No matching test cases were run"` when XCTest has no tests matching passed `--filter` arguments. A third PR after these two have been merged will restore that functionality by collating results from both XCTest and Swift Testing. > [!NOTE] > Test coverage can be added after Swift Testing is in the Swift toolchain. This change partially resolves rdar://131704587.
grynspan
added a commit
that referenced
this pull request
Jul 18, 2024
This PR detects when a Swift Testing run returns `EXIT_NO_TESTS_FOUND` and treats it as a successful test run. This change handles the change from swiftlang/swift-testing#536. Separately, the refactor in #7766 stops Swift Package Manager from reporting `"No matching test cases were run"` when XCTest has no tests matching passed `--filter` arguments. A third PR after these two have been merged will restore that functionality by collating results from both XCTest and Swift Testing. > [!NOTE] > Test coverage can be added after Swift Testing is in the Swift toolchain. This change partially resolves rdar://131704587.
grynspan
added a commit
that referenced
this pull request
Jul 19, 2024
…Swift Testing enabled by default.) (#7794) **Explanation:** Refactors the previously-experimental Swift Testing support logic so that only a single build product is produced when using both XCTest and Swift Testing, and detection of Swift Testing usage is no longer needed at compile time. **Scope:** Implementation of Swift Testing/SwiftPM integration; touches mostly `swift test` but affects `swift build` and `swift package init` as well. **Issue:** rdar://120864035 **Original PR:** #7777, #7789, #7796 **Risk:** Moderate—refactors how we build and run tests. **Testing:** Existing test coverage in the package as well as test coverage in the Swift Testing package; additional integration testing will be added once Swift Testing is in the toolchain. **Reviewer:** @bnbarham @xedin @briancroom @dennisweissmann --------- Co-authored-by: Pavel Yaskevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR detects when a Swift Testing run returns
EXIT_NO_TESTS_FOUNDand treats it as a successful test run.This change handles the change from swiftlang/swift-testing#536. Separately, the refactor in #7766 stops Swift Package Manager from reporting
"No matching test cases were run"when XCTest has no tests matching passed--filterarguments. A third PR after these two have been merged will restore that functionality by collating results from both XCTest and Swift Testing.Note
Test coverage can be added after Swift Testing is in the Swift toolchain.
This change partially resolves rdar://131704587.